Skip to content

docs: Fix example hightlight in functional-components.md #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

Alex-Sokolov
Copy link
Contributor

Correctly highlight changed lines in example with functional component

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line highlighting change looks good to me.

The language is wrong though. Both SFCs should really be vue rather than js, otherwise the template doesn't get the correct syntax highlighting. That can be fixed separately though: a quick search suggests there are a few other examples with the same problem elsewhere in the docs.

@NataliaTepluhina NataliaTepluhina merged commit 93f7b01 into vuejs:master Jan 6, 2021
@Alex-Sokolov Alex-Sokolov deleted the patch-2 branch January 6, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants