Skip to content

fix: error option in async component migration page #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2020
Merged

fix: error option in async component migration page #759

merged 1 commit into from
Dec 22, 2020

Conversation

lovetingyuan
Copy link
Contributor

Description of Problem

Wrong option field in async component migration page: https://v3.vuejs.org/guide/migration/async-components.html#_3-x-syntax.

Proposed Solution

change the wrong option name to correct ones.

Additional Information

image

skirtles-code
skirtles-code approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm unclear why that example is needed. It doesn't really add anything that isn't included in the previous example. With a small tweak to the wording of the sentence about the loader option, I think we could remove the example altogether.

@NataliaTepluhina NataliaTepluhina merged commit 9d48e28 into vuejs:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

@skirtles-code skirtles-code skirtles-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lovetingyuan @NataliaTepluhina @skirtles-code