Changed a recommendation for custom events name casing #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirtles-code
approved these changes
Dec 22, 2020
Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com>
|
@skirtles-code thank you for the suggestion! I better trust a native speaker on this matter 😅 I believe we should add the entry to styleguide, next to props section, I will add one there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Out current recommendation for custom events name casing are outdated (since
emitscan have an object syntax and in this case, camelCased event name is more natural)Proposed Solution
Change recommendation for events name casing to make it consistent with props
Additional Information
Close #656