fix: remove NavBar CSS that was interfering with algolia #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaTepluhina
approved these changes
Oct 18, 2020
nick-lai
pushed a commit
to nick-lai/docs-next
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Originally reported in #556, there's an vertical alignment problem with the text of the 'buttons' in the search box. The specifics vary depending on the platform but here's an example:
The text is supposed to be central but instead it's at the top of the buttons.
Further, on small screens the search box is supposed to hide those buttons but currently it does not.
Both problems are caused by the same CSS.
NavBar.vuesetsdisplay: inline-blockfor all descendent<span>elements, which includes the search box.Proposed Solution
I have removed the relevant CSS.
Testing across various platforms I wasn't able to see any visible change to the
NavBar, aside from the desired changes to the search box. The various<span>elements are now a few pixels shorter but that change isn't visible and I don't believe it impacts the clickable area of the surrounding elements.Additional Information
There are other problems with that header in narrowish viewports. Content starts overlapping long before the media query breakpoints kick in. That isn't directly related to this change so I haven't attempted a fix here.