Skip to content

fix: remove parentheses from the video player configuration #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

skirtles-code
Copy link
Contributor

@skirtles-code skirtles-code commented Oct 13, 2020

Description of Problem

Every page of the docs has <[object Object]> at the top. Most of the time you can't see it. It's easiest to see on the 404 page, e.g. https://v3.vuejs.org/404


404 screenshot


As noted in #556, it can also be seen on other pages using some mobile browsers.

Proposed Solution

Example: https://deploy-preview-622--vue-docs-next-preview.netlify.app/404

It is caused by a pair of parentheses in config.js:

[
  ('script',
  {
    src: 'https://player.vimeo.com/api/player.js'
  })
],

In this PR I have removed those parentheses.

I am unclear whether this is the correct fix. Whatever that configuration setting was supposed to do, it doesn't seem to matter that it wasn't working. It may be that it can be removed instead.

Additional Information

That section of the configuration was originally introduced by @phanan in #71. At that point it didn't have the parentheses. Effectively I am restoring the configuration to how it was at that point.

The parentheses were added in #543. I can't see anything in that PR that indicates that this was an intentional change.

Does anyone have a clear idea why that section is needed at all?

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skirtles-code thank you for the fix! I think they were introduced accidentally when changing the vuepress config

@NataliaTepluhina NataliaTepluhina merged commit 057f7f7 into vuejs:master Oct 14, 2020
nick-lai pushed a commit to nick-lai/docs-next that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants