fix: remove parentheses from the video player configuration #622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Every page of the docs has
<[object Object]>
at the top. Most of the time you can't see it. It's easiest to see on the 404 page, e.g. https://v3.vuejs.org/404As noted in #556, it can also be seen on other pages using some mobile browsers.
Proposed Solution
Example: https://deploy-preview-622--vue-docs-next-preview.netlify.app/404
It is caused by a pair of parentheses in
config.js
:In this PR I have removed those parentheses.
I am unclear whether this is the correct fix. Whatever that configuration setting was supposed to do, it doesn't seem to matter that it wasn't working. It may be that it can be removed instead.
Additional Information
That section of the configuration was originally introduced by @phanan in #71. At that point it didn't have the parentheses. Effectively I am restoring the configuration to how it was at that point.
The parentheses were added in #543. I can't see anything in that PR that indicates that this was an intentional change.
Does anyone have a clear idea why that section is needed at all?