Skip to content

Migrate mixins & custom directives #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 15, 2020
Merged

Conversation

NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented Mar 29, 2020

This PR implements a part of #17

@NataliaTepluhina NataliaTepluhina added content Issues / PRs related to docs content enhancement New feature or request labels Mar 29, 2020
@NataliaTepluhina NataliaTepluhina added this to the alpha milestone Mar 29, 2020
@NataliaTepluhina NataliaTepluhina changed the title WIP: Migrate Reusability & Composition Migrate mixins & custom directives Mar 31, 2020
Copy link
Member

@phanan phanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two minor suggestions, but other than those LGTM! Nice job!

NataliaTepluhina and others added 6 commits April 9, 2020 15:46
Co-Authored-By: Rahul Kadyan <hi@znck.me>
Co-Authored-By: Rahul Kadyan <hi@znck.me>
Co-Authored-By: Rahul Kadyan <hi@znck.me>
Co-Authored-By: Rahul Kadyan <hi@znck.me>
@NataliaTepluhina
Copy link
Member Author

@znck thank you so much for awesome suggestions! I've applied most of them and done some rewrites accordingly. Could you please give it a second round of review?

@NataliaTepluhina NataliaTepluhina requested a review from znck April 11, 2020 13:55
@NataliaTepluhina NataliaTepluhina merged commit c210a01 into master Apr 15, 2020
@NataliaTepluhina NataliaTepluhina deleted the reuse-and-composition branch May 4, 2020 04:18
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
…lint-v2

批量修复部分文本格式细节
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues / PRs related to docs content enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants