Update transitions-enterleave.md #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirtles-code
commented
Oct 2, 2020
NataliaTepluhina
approved these changes
Oct 3, 2020
There was a problem hiding this comment.
@skirtles-code thank you for all the changes! I've added a link to codepen and will be happy to merge as soon as the suggestion is accepted
|
Thank you so much @skirtles-code and @NataliaTepluhina! |
nick-lai
pushed a commit
to nick-lai/docs-next
that referenced
this pull request
Dec 2, 2020
* fix: remove references to old versions of Vue 2 * fix: comment out TODOs * fix: update references to v-enter and v-leave * fix: update an example to match the CodePen * fix: correct typos * fix: introduce some articles to improve the flow * fix: migrate an example to Vue 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various problems with
transitions-enterleave.md.Deployed: https://deploy-preview-581--vue-docs-next-preview.netlify.app/guide/transitions-enterleave.html
The biggest change is migrating the final example to Vue 3.
I've commented inline on the changes.