Skip to content

Remove blank lines from an example that shouldn't have them #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

skirtles-code
Copy link
Contributor

Description of Problem

The style guide has an example intended to show component options without blank lines between them.

This example acquired blank lines during the migration to Vue 3, so it no longer makes sense.

Proposed Solution

I have removed the blank lines to match the Vue 2 example.

Additional Information

See the second example in:

Vue 2: https://vuejs.org/v2/style-guide/#Empty-lines-in-component-instance-options-recommended
Vue 3: https://v3.vuejs.org/style-guide/#empty-lines-in-component-instance-options-recommended

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skirtles-code thank you for the fix, looks good to me 👍🏻

@NataliaTepluhina NataliaTepluhina merged commit c252752 into vuejs:master Sep 30, 2020
nick-lai pushed a commit to nick-lai/docs-next that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants