Skip to content

fix (#516): incorrect examples codepen #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2020
Merged

fix (#516): incorrect examples codepen #551

merged 3 commits into from
Sep 25, 2020

Conversation

bencodezen
Copy link
Member

@bencodezen bencodezen commented Sep 25, 2020 •
edited
Loading

Closes #516

NataliaTepluhina
NataliaTepluhina approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bencodezen looks good to me! 👍🏻

@NataliaTepluhina NataliaTepluhina merged commit edcf1b1 into master Sep 25, 2020
This was referenced Sep 26, 2020
Closed
Closed
nick-lai pushed a commit to nick-lai/docs-next that referenced this pull request Dec 2, 2020
@bencodezen @nick-lai
fix (vuejs#516): incorrect examples codepen (vuejs#551)
71aa712 
* fix (vuejs#516): update codepen example for modal component

* fix (vuejs#516): update modal component title

* fix (vuejs#516): update grid component example
@NataliaTepluhina NataliaTepluhina deleted the fix-516-incorrect-examples branch February 24, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

@phanan phanan Awaiting requested review from phanan

@sdras sdras Awaiting requested review from sdras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples page: some examples are missing and replaced by wrong ones.
2 participants
@bencodezen @NataliaTepluhina