Dynamic and async components #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliaTepluhina
added
state: blocked
znck
reviewed
Mar 18, 2020
Co-Authored-By: Rahul Kadyan <hi@znck.me>
Co-Authored-By: Rahul Kadyan <hi@znck.me>
|
Removing Will update it to the new syntax and resolve a WIP status today |
NataliaTepluhina
removed
the
state: blocked
NataliaTepluhina
force-pushed
the
component-dynamic-async
branch
from
1a4149e to
4c9763a
Compare
NataliaTepluhina
changed the title
|
I've updated the description with alpha-11 syntax 🎉 A PR is ready for review now |
znck
reviewed
Apr 7, 2020
Co-Authored-By: Rahul Kadyan <hi@znck.me>
|
@znck As for codepens: I don't think we can make them resizeable 🤔 |
|
@NataliaTepluhina Pens can be resizable, like this: .cp_embed_wrapper {
overflow: hidden;
resize: both;
}
.cp_embed_wrapper iframe {
height: 100% !important;
} |
…into component-dynamic-async
|
@znck implemented all the required changes, could you please take a second look? |
znck
reviewed
Apr 14, 2020
Co-Authored-By: Rahul Kadyan <hi@znck.me>
…into component-dynamic-async
|
@znck Added more requested changes, back to you ⚽ |
znck
approved these changes
Apr 15, 2020
|
👏 Looks great, nothing more from my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked until we merge Suspense with
createAsyncComponentmethod