Skip to content

Provide/inject #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Mar 12, 2020
Merged

Provide/inject #48

merged 22 commits into from
Mar 12, 2020

Conversation

NataliaTepluhina
Copy link
Member

I moved 'provide/inject' outside from Handling edge cases chapter

NataliaTepluhina
NataliaTepluhina commented Feb 25, 2020
View reviewed changes
src/guide/component-provide-inject.md
- ancestor components don’t need to know which descendants use the properties it provides
- descendant components don’t need to know where injected properties are coming from

## Working with reactivity
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started this chapter here but the more I work on it the more I think it should belong to Composition API. Maybe it would be a good idea to just state provide/inject is not reactive by default and say that if you want to make it reactive, you should look into Composition API chapter Making provide/inject reactive or something like this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel same, we can introduce to idea here and expand on reactivity on composition API section. However, in my opinion, the following section should be here and we can further link it composition API section.

@NataliaTepluhina
Copy link
Member Author

@znck could you please take an early look at this? Any changes / additions are much appreciated!

@NataliaTepluhina NataliaTepluhina added content Issues / PRs related to docs content enhancement New feature or request labels Feb 25, 2020
@NataliaTepluhina NataliaTepluhina added this to the alpha milestone Feb 25, 2020
znck
znck reviewed Feb 27, 2020
View reviewed changes
Copy link
Member

@znck znck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. I recommend we change text in default slot behaviour section, see comments.

src/guide/component-provide-inject.md
- ancestor components don’t need to know which descendants use the properties it provides
- descendant components don’t need to know where injected properties are coming from

## Working with reactivity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel same, we can introduce to idea here and expand on reactivity on composition API section. However, in my opinion, the following section should be here and we can further link it composition API section.

NataliaTepluhina and others added 5 commits February 28, 2020 16:49
@NataliaTepluhina @bencodezen
Update src/guide/component-slots.md
21ca76b 
Co-Authored-By: Ben Hong <ben@bencodezen.io>
@NataliaTepluhina @bencodezen
Update src/guide/component-slots.md
895731f 
Co-Authored-By: Ben Hong <ben@bencodezen.io>
@NataliaTepluhina @bencodezen
Update src/guide/component-slots.md
877a318 
Co-Authored-By: Ben Hong <ben@bencodezen.io>
@NataliaTepluhina @bencodezen
Update src/guide/component-slots.md
1c0dc36 
Co-Authored-By: Ben Hong <ben@bencodezen.io>
@NataliaTepluhina @bencodezen
Update src/guide/component-slots.md
3f36e0d 
Co-Authored-By: Ben Hong <ben@bencodezen.io>
@NataliaTepluhina NataliaTepluhina force-pushed the component-dependency-injection branch from 8d8305e to a861494 Compare February 28, 2020 15:07
@NataliaTepluhina NataliaTepluhina force-pushed the component-dependency-injection branch from a861494 to d2dfb57 Compare February 28, 2020 15:14
@NataliaTepluhina
Copy link
Member Author

@znck I've done some fixes, could you please give it another round of review?

@NataliaTepluhina NataliaTepluhina requested a review from znck March 9, 2020 06:18
@NataliaTepluhina NataliaTepluhina changed the title WIP: Provide/inject Provide/inject Mar 11, 2020
znck
znck reviewed Mar 12, 2020
View reviewed changes
Copy link
Member

@znck znck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now!

@NataliaTepluhina NataliaTepluhina merged commit e33bdc8 into master Mar 12, 2020
@NataliaTepluhina NataliaTepluhina deleted the component-dependency-injection branch May 4, 2020 04:18
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
@mortal-link
docs: update state-management.md (vuejs#48)
407c2bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znck znck znck left review comments

Assignees

@znck znck

Labels
content Issues / PRs related to docs content enhancement New feature or request
Projects
None yet
Milestone
alpha
Development

Successfully merging this pull request may close these issues.
2 participants
@NataliaTepluhina @znck