Skip to content

fix: Change the options object - defineAsyncComponent #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2020
Merged

fix: Change the options object - defineAsyncComponent #458

merged 1 commit into from
Sep 19, 2020

Conversation

zhenzhenChange
Copy link
Contributor

fix: Change the options object: remove the retryWhen, maxRetries attributes, add the onError event, and attach a comment

@zhenzhenChange
fix: Change the options object: remove the retryWhen, maxRetries …
ff11246 
…attributes, add the `onError` event, and attach a comment
NataliaTepluhina
NataliaTepluhina approved these changes Sep 19, 2020
View reviewed changes
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhenzhenChange thank you for the fix!

@NataliaTepluhina NataliaTepluhina merged commit 37ba7d2 into vuejs:master Sep 19, 2020
@zhenzhenChange zhenzhenChange deleted the fix-global-api-defineAsyncComponent branch September 19, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenzhenChange @NataliaTepluhina