Fix createApp and mount usage #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 26, 2020 16:44
bencodezen
reviewed
Jan 26, 2020
| .reverse() | ||
| .join('') | ||
| } | ||
| const vm = Vue.createApp({ |
bencodezen
approved these changes
Jan 26, 2020
|
@NataliaTepluhina Ready to merge! |
|
Folks, per Vue’s coding style there should always be a space after function
names e.g. `data ()` instead of `data()`. We kind of miss this entirely in
the PRs so far.
Ben Hong <notifications@github.com> schrieb am Mo. 27. Jan. 2020 um 06:35:
… @NataliaTepluhina <https://github.com/NataliaTepluhina> Ready to merge!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#40>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5O3UQVT7VNQ5ZIP6P736TQ7YM5LANCNFSM4KLXSESA>
.
|
|
@phanan maybe should we switch to ESLint for the docs? From what I can see it allows to set up a rule for space before parentheses while Prettier deprecated this rule. |
TalexDreamSoul
pushed a commit
to Talexs/docs
that referenced
this pull request
Apr 17, 2022
* docs(computed): review src\guide\essentials\computed.md * Apply suggestions from code review Co-authored-by: wxsm <wxsms@foxmail.com> Co-authored-by: Wang Weitao <softweitao@126.com> * Update src/guide/essentials/computed.md Co-authored-by: wxsm <wxsms@foxmail.com> * Update src/guide/essentials/computed.md Co-authored-by: wxsm <wxsms@foxmail.com> * upadte * update (vuejs#40) * update * Update src/guide/essentials/computed.md Co-authored-by: wxsm <wxsms@foxmail.com> Co-authored-by: Wang Weitao <softweitao@126.com> Co-authored-by: Jinjiang <zhaojinjiang@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to vuejs/core@7fbc3ba I've changed the examples with
createAppandmountto match changed signatures