Add readonly import to code sample #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not completely sure the rules for when to have the vue imports in code samples, but not having this one threw me because the ones directly above do have the imports, and it seems each vue function is imported at least once in the example code. I spent some time checking if readonly was a native javascript feature of proxies since I've never actually worked with them. Showing the import should quickly clear up where it's coming form.
NataliaTepluhina
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not completely sure the rules for when to have the vue imports in code samples, but not having this one threw me because the ones directly above do have the imports, and it seems each vue function is imported at least once in the example code.
I spent some time checking if readonly was a native javascript feature of proxies since I've never actually worked with them. Showing the import should quickly clear up where it's coming form.