Skip to content

Added outerHTML -> innerHTML el change to docs #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

NataliaTepluhina
Copy link
Member

As described in #335, we need to highlight the change regarding the application container on the migration guide: now on mounting an app, we use container innerHTML instead of outerHTML as it was on 2.x. I've also changed the lifecycle hooks diagram to reflect this change

Close #335

@NataliaTepluhina NataliaTepluhina added the enhancement New feature or request label Aug 2, 2020
@NataliaTepluhina NataliaTepluhina self-assigned this Aug 2, 2020
Copy link
Member

@phanan phanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Except, have you tried compressing the PNG file? Using ImageOptim yielded a better result (172KB) for my export locally.

@NataliaTepluhina
Copy link
Member Author

Thanks @phanan! Let me try to optimize it 😅

@bencodezen bencodezen merged commit 7029803 into master Aug 3, 2020
@NataliaTepluhina NataliaTepluhina deleted the fix-lifecycle-hooks branch February 24, 2021 08:33
alexeyvokin pushed a commit to alexeyvokin/docs-ru_old that referenced this pull request Apr 1, 2024
Co-authored-by: mnenie <121057011+mneniee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration guide: document changes in mounting point
3 participants