Skip to content

Switch teleport example to real world scenario #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 30, 2020

Conversation

marina-mosti
Copy link
Collaborator

Issue #321

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marina-mosti thank you for working on this! I've added a few comments regarding MR

@bencodezen
Copy link
Member

Great job @marina-mosti! Once the comments from @NataliaTepluhina are addressed it is a 👍 from me!

@marina-mosti
Copy link
Collaborator Author

Thanks for the review @NataliaTepluhina and @bencodezen
I've applied the suggestions and modified the codepen, it has to be copied over to the Vue account if approved though.

https://codepen.io/immarina/pen/QWyPmOj

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marina-mosti thank you for fixing this! I've added a forked codepen and a small fix, as soon as they're accepted, we're ready to merge

marina-mosti and others added 2 commits July 30, 2020 14:53
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
@marina-mosti
Copy link
Collaborator Author

Thanks for the double check @NataliaTepluhina
I think were good to go

@NataliaTepluhina NataliaTepluhina merged commit c932c3c into vuejs:master Jul 30, 2020
alexeyvokin pushed a commit to alexeyvokin/docs-ru_old that referenced this pull request Apr 1, 2024
Обновление исходников до актуального состояния
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants