Skip to content

Move conditional rendering and list rendering #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 22, 2020
Merged

Move conditional rendering and list rendering #33

merged 6 commits into from
Jan 22, 2020

Conversation

NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented Jan 9, 2020 •
edited
Loading

Wins:

  • got rid of Array and Object change detection caveats 🎉
  • changed sidebar structure a bit

@NataliaTepluhina NataliaTepluhina mentioned this pull request Jan 9, 2020
Closed
bencodezen
bencodezen reviewed Jan 10, 2020
View reviewed changes
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NataliaTepluhina Just a couple of questions. Back to you!

@bencodezen bencodezen added this to the alpha milestone Jan 10, 2020
@bencodezen bencodezen added enhancement New feature or request content Issues / PRs related to docs content labels Jan 10, 2020
@NataliaTepluhina
Copy link
Member Author

@bencodezen @phanan thanks for your comments 🙇‍♀

I've addressed them, could you please take a second look?

@bencodezen
Copy link
Member

@NataliaTepluhina Small merge conflict. I believe you want what's on this branch over master, but didn't want to assume.

@NataliaTepluhina
Copy link
Member Author

@bencodezen conflicts resolved, merging :)

@NataliaTepluhina NataliaTepluhina merged commit 9216e43 into master Jan 22, 2020
@NataliaTepluhina NataliaTepluhina deleted the move-conditional-rendering branch May 4, 2020 04:17
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
@veaba
Merge pull request vuejs#33 from lxb007981/main
ac8a7d4 
docs: fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencodezen bencodezen bencodezen approved these changes

@phanan phanan Awaiting requested review from phanan

@sdras sdras Awaiting requested review from sdras

Assignees

@NataliaTepluhina NataliaTepluhina

Labels
content Issues / PRs related to docs content enhancement New feature or request
Projects
None yet
Milestone
alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@NataliaTepluhina @bencodezen @phanan