Skip to content

Register ScrimbaLink component and change color on play button #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

perborgen
Copy link
Contributor

Description of Problem

I forgot to register the ScrimbaLink component to it didn't render. Also had a darker color than the other similar links across the site.

Proposed Solution

Registered component in index.tsx in theme, and make the color inline with other similar links.

Copy link

netlify bot commented May 29, 2025

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit fc99592
🔍 Latest deploy log https://app.netlify.com/projects/vuejs/deploys/68380758ac6b55000864f4dc
😎 Deploy Preview https://deploy-preview-3242--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yyx990803 yyx990803 merged commit 54d0d23 into vuejs:main May 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants