Skip to content

docs: remove duplicate defineOptions script setup example #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

hwkr
Copy link
Contributor

@hwkr hwkr commented Jun 26, 2023

removes an old example that used to document using defineOptions without a setup but now says the same thing twice

Description of Problem

The docs recommend using the defineOptions macro twice. Looks like it was changed in PR #2384 to always suggest always using <script setup> but it didn't remove the second example.

Proposed Solution

Remove the first example. (Could remove the other too though 🤷‍♀️ )

removes an old example that used to document using defineOptions without a setup but now says the same thing twice
@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit df07404
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/649a1e1dde55a500080ece16
😎 Deploy Preview https://deploy-preview-2422--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants