Skip to content

Styles: Responsive for Preference Switch #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 18, 2023
Merged

Conversation

sergiopani
Copy link
Contributor

Changing the responsive styles from the preferenced options on less 960px of screen.

Before:

Captura de Pantalla 2023-03-12 a las 14 29 30

Now:

Captura de Pantalla 2023-03-12 a las 14 29 06

@netlify
Copy link

netlify bot commented Mar 12, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 6b47f83
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/64122c18d96d670008c7243d
😎 Deploy Preview https://deploy-preview-2285--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@skirtles-code skirtles-code changed the title Sytles: Responsive for Preference Switch Styles: Responsive for Preference Switch Mar 14, 2023
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement. This does look better.

I've made some suggestions below. If you could address those then I think we can merge this.

@sergiopani sergiopani closed this Mar 14, 2023
@sergiopani sergiopani reopened this Mar 14, 2023
@sergiopani
Copy link
Contributor Author

Okey i made the changes!

sergiopani and others added 2 commits March 15, 2023 21:32
Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com>
@sergiopani
Copy link
Contributor Author

At least! As a first-time contributor, I was not familiar with the process of accepting changes made to my code on github. I appreciate your patience!

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@skirtles-code skirtles-code merged commit 127093f into vuejs:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants