Skip to content

docs: fix aria-labelledby example. #2195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

ByMykel
Copy link
Contributor

@ByMykel ByMykel commented Jan 28, 2023

Description of Problem

The id used in the aria-labelledby attribute is duplicated.

Proposed Solution

Change the id's to make them unique.

@netlify
Copy link

netlify bot commented Jan 28, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 4923a5e
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/63d5963b4f247c00090784d5
😎 Deploy Preview https://deploy-preview-2195--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@skirtles-code skirtles-code merged commit c978453 into vuejs:main Jan 29, 2023
@ByMykel ByMykel deleted the docs/fix-example branch January 29, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants