Fix Testing Library example #1904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
skirtles-code
approved these changes
Aug 14, 2022
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 16, 2022
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 22, 2022
* Add a note about `flush: 'sync'`, with links from elsewhere (#1895) * Update the note about Vue Router and lazy loading (#1896) * Fix Testing Library example (#1904) Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com> Co-authored-by: Noel De Martin <noel@noeldemartin.com>
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 22, 2022
* Add a note about `flush: 'sync'`, with links from elsewhere (#1895) * Update the note about Vue Router and lazy loading (#1896) * Fix Testing Library example (#1904) * 📝 Composition api is available in Vue 2.7 (#1909) Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com> Co-authored-by: Noel De Martin <noel@noeldemartin.com> Co-authored-by: Viki Val <viktorko99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
I think the current example is wrong. It seems to render the component twice and uses different variable names for it (
ComponentvsStepper).Proposed Solution
I guess the proper solution is to refer to the component as
Stepper, like in the rest of the examples, and render only once.