Update the note about Vue Router and lazy loading #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 16, 2022
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 22, 2022
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 22, 2022
* Add a note about `flush: 'sync'`, with links from elsewhere (#1895) * Update the note about Vue Router and lazy loading (#1896) * Fix Testing Library example (#1904) Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com> Co-authored-by: Noel De Martin <noel@noeldemartin.com>
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 22, 2022
* Add a note about `flush: 'sync'`, with links from elsewhere (#1895) * Update the note about Vue Router and lazy loading (#1896) * Fix Testing Library example (#1904) * 📝 Composition api is available in Vue 2.7 (#1909) Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com> Co-authored-by: Noel De Martin <noel@noeldemartin.com> Co-authored-by: Viki Val <viktorko99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by the change proposed in #1869.
In Vue 2, Vue Router used Async Components for the lazy loading of route components. However, in Vue 3 these are two similar but distinct features. The description in
performance.mdhasn't taken this separation into account.The main change is to the paragraph describing the use of lazy loading with Vue Router. This has been updated to reflect the separation between these two features.
I've also tweaked an earlier paragraph to remove the word 'typically'. I think that was a little misleading in a Vue 3 context, as lazy loaded routes are more typical than explicitly using
defineAsyncComponent.