Skip to content

Support dynamic loading of special sponsors #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

Support dynamic loading of special sponsors #1838

merged 1 commit into from
Jul 21, 2022

Conversation

Jinjiang
Copy link
Member

Description of Problem

#1830

Proposed Solution

  • Sharing sponsors' data loading logic to an independent ts file.
  • Load the data into the home page.

Additional Information

  • BTW, made the sponsor link target from self to _blank.

@netlify
Copy link

netlify bot commented Jul 18, 2022 •
edited
Loading

✅ Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 7250570
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/62d5599893d91d00086d0da7
😎 Deploy Preview https://deploy-preview-1838--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NataliaTepluhina NataliaTepluhina merged commit abd953b into vuejs:main Jul 21, 2022
@Jinjiang Jinjiang deleted the jinjiang/sponsors branch July 22, 2022 13:05
@Jinjiang Jinjiang mentioned this pull request Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NataliaTepluhina NataliaTepluhina NataliaTepluhina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jinjiang @NataliaTepluhina