-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feature (#169): add migration badges #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bencodezen just my chaotic thoughs
- badges look cool! I'm not sure about the placement - should it be above title, inline or under
core
,directives
etc is a bit confusing to me as tbh as it's hard to define the finite list of such categories- AsyncComponents are breaking too! (current async imports will stop working)
Yeah I was trying to use the labels that were in the RFCs repo, but I don't think it makes sense to use what's in there. For now, maybe we can start with the following generic badges:
|
The Netlify preview is gone for some reason. @bencodezen maybe a rebuild? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make a lot of sense to me, I didn't see anything breaking about your PR about breaking, haha
Looks like there are some merge conflicts and then we're good to go, @bencodezen |
* fix: Consistent with English documents * fix: be singular
Netlify Preview
Still not sure about the full list of what we want to include and how to tag things appropriately.
Maybe the badges should only be used next to the bulleted items in each overview section? That way it doesn't seem like the entire thing is broken or that an entire feature is removed?
Also, styles are totally up for feedback / changes. Just iterating along the way!
Closes #169