Skip to content

Replaced codepen in Accessibility -> Placeholder with playground link #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented Jun 16, 2022

Description of Problem

Currently, Accessibility guide is missing code examples. This PR fixes the issue for the placeholder example

Additional Information

I'll create a follow-up PR to replace all codepens with playground links

Close #1532

@netlify
Copy link

netlify bot commented Jun 16, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 1f79bbd
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/62bada005bfb1500081ddb93
😎 Deploy Preview https://deploy-preview-1777--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we actually need to show the code for this example directly in the docs? Isn't the point of the example just to show that black placeholder text looks like pre-populated data?

@NataliaTepluhina
Copy link
Member Author

@skirtles-code do you recommend removing the code and the snippet and leaving only a screenshot?

@skirtles-code skirtles-code changed the title Replaced codepen in Accesibility -> Placeholder with playground link Replaced codepen in Accessibility -> Placeholder with playground link Jul 4, 2022
@skirtles-code skirtles-code merged commit da406ac into main Jul 4, 2022
@skirtles-code skirtles-code deleted the fix-placeholder-snippet branch July 4, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example in Guide/Best Practices/Accessibility#Placeholder is missing
2 participants