Skip to content

Update Vue School banner copy #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Update Vue School banner copy #1690

merged 1 commit into from
Apr 30, 2022

Conversation

nicodevs
Copy link
Contributor

This PR updates the text of the Vue School top banner to announce the promo is extended for 48 hs.

Please merge this on 2022-05-01T00:00:00+02:00 (so, on the first minute of Sunday, or soon later).

The banner will stop appearing automatically on 2022-05-04T00:00:00+02:00, the date is hard-coded.

Click here to see screenshots of the banner

@netlify
Copy link

netlify bot commented Apr 28, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit ddfe698
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/626a90023c35ab0008f60087
😎 Deploy Preview https://deploy-preview-1690--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@skirtles-code
Copy link
Contributor

@nicodevs Just to confirm the timings, the times you mentioned are 72 hours apart, but the text says 48 hours. Is that correct?

@nicodevs
Copy link
Contributor Author

Thanks for checking @skirtles-code👍 Yes, timing are correct, the promo will auto extend up to the end date.

@skirtles-code skirtles-code merged commit 67db2a5 into vuejs:main Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants