Skip to content

fix: banner height error #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: banner height error #1686

merged 1 commit into from
Apr 25, 2022

Conversation

Jiangmenghao
Copy link
Contributor

Description of Problem

Wrong banner height(Vue School Banner) leads to wrong nav-bar position

Proposed Solution

VueSchoolBanner.vue:

.has-top-banner {
  --vt-banner-height: 80px;
}

Additional Information

Screen Shot 2022-04-25 at 17.54.25.png

@netlify
Copy link

netlify bot commented Apr 25, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit d97981d
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/62667161a8ed380008c7a27c
😎 Deploy Preview https://deploy-preview-1686--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skirtles-code skirtles-code merged commit 62caca6 into vuejs:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants