Fix examples in HTML mode #1636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1634.
Several of the examples don't work correctly if the HTML/SFC switch is set to HTML.
The main problem is that
<input />
and<br />
is transformed to<input></input>
and<br></br>
. For some examples this is harmless and just leads to strange-looking code, but for other examples it breaks the parsing, leading to incorrect rendering or an error.Rather than fixing the transform I've just removed the unnecessary closing slash from those tags.
There were also a couple of problems with the Circle Drawer demo. These only applied to the Composition API version. Two things used in the template were not being returned from
setup
. In SFC mode this still worked because thereturn
is stripped out by a transform, but in HTML mode thatreturn
needs to return the correct things.