Skip to content

Improve clarity of a sentence in the "Lifecycle Hooks" section of the docs #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2022

Conversation

jonksc
Copy link
Contributor

@jonksc jonksc commented Mar 5, 2022

Description of Problem

Do note this doesn't mean that the call must be placed lexically inside setup() or <script setup> - onMounted() can be called in an external function as long as the call stack is synchronous and originates from within setup().

The dash in this sentence makes it look like it's <script setup> - onMounted(), when in fact they should be separate.

Proposed Solution

To improve clarity and flow of the sentence, I suggest using a fullstop instead.

@netlify
Copy link

netlify bot commented Mar 5, 2022

✔️ Deploy Preview for vuejs ready!

🔨 Explore the source changes: 560a83e

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/622376b88b8ee60007f8cac9

😎 Browse the preview: https://deploy-preview-1597--vuejs.netlify.app

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skirtles-code skirtles-code merged commit 73ea57a into vuejs:main Mar 6, 2022
@jonksc jonksc deleted the patch-2 branch March 6, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants