Skip to content

add Vue School links #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022
Merged

add Vue School links #1546

merged 2 commits into from
Feb 22, 2022

Conversation

danielkellyio
Copy link
Contributor

Add video content by Vue School to support written documentation. Links all refer to those previously discussed with Evan.

Here's what they look like in both light and dark mode:

Screen Shot 2022-02-14 at 4 44 24 PM

Screen Shot 2022-02-14 at 4 44 55 PM

Thanks!

@netlify
Copy link

netlify bot commented Feb 14, 2022

✔️ Deploy Preview for vuejs ready!

🔨 Explore the source changes: d123362

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/620bb9b3374b9f0007719015

😎 Browse the preview: https://deploy-preview-1546--vuejs.netlify.app

@skirtles-code
Copy link
Contributor

There's currently a merge conflict.

Are these the exact same videos that were previously added to the old Vue 3 docs?

When you say 'previously discussed with Evan', do you mean in the context of the new docs? I seem to recall Evan mentioning reworking the video links in the new docs, but I'm unclear exactly what his plans were.

@danielkellyio
Copy link
Contributor Author

danielkellyio commented Feb 15, 2022

hey @skirtles-code my apologies on the merge conflict, I've now resolved that.
As far as discussing these links with Evan, these are not all the exact same links as before. In fact, many of them have been reproduced for better quality and cohesion with the new docs.

Evan and I corresponded on discord and in a notion doc to discuss link placements.

Thanks!

@danielkellyio
Copy link
Contributor Author

@skirtles-code to clarify my above comment @yyx990803 has approved the links in this PR via the notion doc. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants