Skip to content

docs: Change is prop to is attribute #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

Yukon123
Copy link

Description of Problem

is is special attribute

https://v3.cn.vuejs.org/api/special-attributes.html#is

Proposed Solution

Change is prop to is attr

Additional Information

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yukon123 I totally agree with your point 👍🏻 Could we please replace attr with attribute for all occurrences?

@NataliaTepluhina
Copy link
Member

@Yukon123 thank you for the fixes!

@NataliaTepluhina NataliaTepluhina merged commit 9ed94d8 into vuejs:master Aug 24, 2021
@Yukon123 Yukon123 deleted the patch-10 branch August 24, 2021 13:51
@Yukon123 Yukon123 changed the title Change is prop to is attr docs: Change is prop to is attr Aug 25, 2021
@Yukon123 Yukon123 changed the title docs: Change is prop to is attr docs: Change is prop to is attribute Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants