Skip to content

Add various improvements to the Events API migration guide #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

skirtles-code
Copy link
Contributor

The main changes here are:

  1. Rename event hub to event bus.
  2. Add some content discouraging the use of event buses. I've seen several examples on Discord where people used this page as proof that an event bus is an officially-endorsed strategy for handling component communication.
  3. Add an explanation about passing events to the root component via createApp.

My bullet-points outlining alternatives to an event bus are somewhat terse. There's a huge amount of material that could be explored on that topic and explaining it in depth would need a whole page to itself. That said, I thought it was important to make some attempt at suggesting alternatives rather than just discouraging event buses.

I've moved the link to the migration build to the top of the 'Migration Strategy' section. I've split that section up into subsections and I didn't want the link to appear in a specific subsection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants