Update Vue School Summer Sale banner #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirtles-code
suggested changes
Jun 23, 2021
There was a problem hiding this comment.
It seems this has introduced large gaps above all the headings. You can see them in the test deployment at https://deploy-preview-1108--vue-docs-next-preview.netlify.app/.
For reference, here's an image that compares the usual headers with what I'm seeing for this PR:
|
@skirtles-code I fixed the issue, let me know if it's OK now. |
skirtles-code
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
The main <h1> heading on most of the pages is too close to the navbar when the banner is showing. But it's the same on the current live site, so I don't see any reason why this should prevent this PR being merged.
The problems in the Style Guide do seem to be fixed and I haven't been able to find any other problems. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the banner on top of v3.vuejs.org to inform visitors that it's only a few hours before the Summer Sale expires.
Please merge on 2021-06-24 around 5:00 pm CEST.
Click here to see the visuals of the banner.
This solves the issue mentioned on #1103
Related to PR 1082