3.1 Updates #1078
Merged
3.1 Updates #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirtles-code
suggested changes
Jun 4, 2021
There was a problem hiding this comment.
Some suggested tweaks from me below.
In addition, I think there are some other pages that will also need updating:
/guide/migration/custom-elements-interop.mdusesv-isand mentionsapp.config.isCustomElement./guide/migration/global-api.mdmentionsapp.config.isCustomElement./style-guide/README.mdmentionsdelimitersand should probably be changed tocompilerOptions.
src/api/application-config.md
Outdated
|
|
||
| - **Default:** `{{ "['\u007b\u007b', '\u007d\u007d']" }}` | ||
|
|
||
| - **Restrictions:** This option is only available in the full build, with in-browser template compilation. |
There was a problem hiding this comment.
Should we remove this line as this restriction applies to all of these settings?
Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com>
Co-authored-by: skirtle <65301168+skirtles-code@users.noreply.github.com>
|
@skirtles-code thanks for the review! Should all be addressed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hold for release.