[WIP] tag PRs using alert blocks #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znck
changed the title
|
@znck Thanks for this PR! As far as your question, I'm thinking it will useful to scope out these labels in case we have other flags we want to check for in the future in docs. So I'm proposing we prefix these flags with So for this one:
And then if we want to check for code samples in the future, it could be:
What do you think? |
|
@znck Just wanted to check in and see if you needed me to do anything else for this PR. Let me know whenever you have a chance. No rush. Thanks! |
bencodezen
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
/cc @bencodezen can you decide what label we want to use?