Skip to content

Bold text does stand out significantly from the regular text #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Blakelist7
Copy link

@Blakelist7 Blakelist7 commented Apr 29, 2021

Made some text more Bold so that they stand out from the regular text.
Partial changes : #844
Can someone please review my PR

@skirtles-code
Copy link
Contributor

Hi @Blakelist7. Thanks for the PR.

Sorry for the delay in getting back to you.

I'm currently doing some research into the history of the docs theme and why it is the way it is. The font-weight for <strong> tags doesn't match the defaults for VuePress and I'd like to understand why before making any decisions. The people involved are all in different timezones so it may take a few more days for me to get to the bottom of it but I'll let you know as soon as I can.

Thanks again for your effort in putting together this PR.

@Blakelist7
Copy link
Author

Blakelist7 commented May 6, 2021

Thanks for acknowledgement.
Once you complete your research, it would benefit people like me if you could share the resources also.

@skirtles-code
Copy link
Contributor

I've opened #1048 to fix this by a different route. I've included the results of my investigation on that PR, though I didn't really get to the bottom of why the font-weight was changed to 500 in the first place.

@Blakelist7 Blakelist7 deleted the docs-enhancement branch May 11, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants