Skip to content

fix: add binding.expression removal to BC list #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: add binding.expression removal to BC list #1005

wants to merge 1 commit into from

Conversation

caugner
Copy link

@caugner caugner commented Apr 22, 2021

Description of Problem

The binding.expression was removed in Vue 3, but this breaking change has not been document yet.

Proposed Solution

Add this removal to the list of breaking changes.

Additional Information

@skirtles-code
Copy link
Contributor

Related: #758

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've included my feedback below.

@@ -118,6 +118,7 @@ The following consists a list of breaking changes from 2.x:
- [`propsData` option](/guide/migration/props-data.html)
- `$destroy` instance method. Users should no longer manually manage the lifecycle of individual Vue components.
- Global functions `set` and `delete`, and the instance methods `$set` and `$delete`. They are no longer required with proxy-based change detection.
- `binding.expression` in [Custom Directives](/guide/migration/custom-directives.html).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear about the link. I think most readers would expect the linked page to provide further information about the removal of binding.expression but it isn't mentioned on that page.

@skirtles-code
Copy link
Contributor

This has now been covered by #1133. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants