Skip to content
This repository was archived by the owner on Aug 8, 2022. It is now read-only.

update: src/guide/migration/global-api-treeshaking.md #493

Closed

Conversation

jiangmaniu
Copy link
Contributor

@jiangmaniu jiangmaniu commented May 10, 2021

Description of Problem

update commit author

Proposed Solution

Additional Information

@veaba veaba self-requested a review May 10, 2021 16:18
@veaba
Copy link
Member

veaba commented May 10, 2021

@jiangmaniu 这是一个冲突的 PR,提交的 PR 是过期的提交。现在的 master 分支内容是正确的,麻烦看下,我先 close。

@veaba veaba closed this May 10, 2021
@jiangmaniu
Copy link
Contributor Author

@veaba 非常感谢您的回复!#216 就是我之前的提交,但是 commit author 对应的邮箱跟我现在不一致,导致没有关联,请问可以将 author 改成我现在的吗?如果可以请问我要怎么做?

@veaba
Copy link
Member

veaba commented May 11, 2021

可以是可以,但不建议这么做,比较危险,容易出问题,我没有把握。

文档还是有很多错误可以参与的。

应该有代码可以替换掉 commiter 的,就是修改 git 历史 commit 用户名和邮箱,可以搜一下。

你可以在自己的分支下测试下效果。

/ cc @Justineo 可以帮忙看看。

@jiangmaniu
Copy link
Contributor Author

@veaba 感谢你的回复,如果麻烦的话就不用了。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants