Skip to content

types: make instrumentations' types more succinct #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

Alfred-Skyblue
Copy link
Member

No description provided.

@Alfred-Skyblue Alfred-Skyblue marked this pull request as ready for review June 12, 2023 15:02
@sxzz sxzz added the ready for review This PR requires more reviews label Aug 15, 2023
@Alfred-Skyblue Alfred-Skyblue changed the title chore: optimize TypeScript types types: optimize typescript type Aug 15, 2023
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.5 kB 34.4 kB 31 kB
vue.global.prod.js 148 kB 53.7 kB 47.9 kB

Usages

Name Size Gzip Brotli
createApp 50.8 kB 19.8 kB 18.1 kB
createSSRApp 54.1 kB 21.2 kB 19.3 kB
defineCustomElement 53 kB 20.6 kB 18.8 kB
overall 64.4 kB 24.9 kB 22.6 kB

Copy link

codspeed-hq bot commented Dec 20, 2023

CodSpeed Performance Report

Merging #8558 will not alter performance

Comparing Alfred-Skyblue:chore-collectionHandlers-type (91d0bec) with main (9fa8241)

Summary

✅ 53 untouched benchmarks

@haoqunjiang
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Mar 13, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify failure success
vueuse success success
vue-simple-compiler success success

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vuetify failure in ecosystem-ci wasn't related to this PR.

@haoqunjiang haoqunjiang added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Mar 13, 2024
@haoqunjiang haoqunjiang merged commit 384591a into vuejs:main Mar 13, 2024
@haoqunjiang haoqunjiang changed the title types: optimize typescript type types: make instrumentations' types more succinct Mar 13, 2024
@Alfred-Skyblue Alfred-Skyblue deleted the chore-collectionHandlers-type branch March 18, 2024 01:39
lynxlangya pushed a commit to lynxlangya/core that referenced this pull request May 30, 2024
Co-authored-by: Haoqun Jiang <haoqunjiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready for review This PR requires more reviews
Projects
Development

Successfully merging this pull request may close these issues.

4 participants