Skip to content

feat(jsx): capture events #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jan 18, 2021

Currently vue tsx definition doesn't support capture events.

image

Copy link
Contributor

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also Once and OnceCapture

@LinusBorg LinusBorg added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Feb 4, 2021
Copy link
Member

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@07akioni this needs a rebase, and it would be great if you could add the other event times mentioned above as well.

@07akioni 07akioni force-pushed the feat-jsx-capture-events branch from 0714432 to 891c4d6 Compare February 5, 2021 03:47
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

Size report

Path Size
vue.global.prod.js 40.56 KB (0%)
runtime-dom.global.prod.js 26.95 KB (0%)
size-check.global.prod.js 16.31 KB (0%)

@07akioni
Copy link
Contributor Author

07akioni commented Feb 5, 2021

It seems the CI fail is irrelevant

@HcySunYang
Copy link
Member

Can this be achieved through LibraryManagedAttributes and Template Literal Types? Instead of enumerating? Like this one #3096

@HcySunYang
Copy link
Member

I did some exploration #3198

@07akioni 07akioni force-pushed the feat-jsx-capture-events branch from bb9c18b to 9729ab5 Compare February 9, 2021 05:14
@07akioni
Copy link
Contributor Author

07akioni commented Feb 9, 2021

I've done some simplification from #3198. (And as mentioned in 3198 prettier doesn't work due to template literal.)

Thanks to @HcySunYang 's idea.

@HcySunYang
Copy link
Member

@07akioni Great, I will close my PR

@yyx990803
Copy link
Member

This introduces reliance on template literal types, which requires TS > 4.1, so I think we should avoid introducing it in a patch release.

I'm not sure if it even makes sense to bump minimum TS compatibility versions in 3.1, but I don't think there are easy ways around this. We'd be either stuck with TS 4.0 and never be able to use template literal types (which is useful in other areas) until next major (unlikely), or we have to introduce a new minimum TS version requirement in a minor release.

@pikax
Copy link
Member

pikax commented Nov 3, 2023

Closing this in favour of #9542

Created a new PR since this PR implementation was not playing nicely with the types when I resolved conflicts

@pikax pikax closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: types
Projects
Status: Rejected
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants