-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
feat(jsx): capture events #3039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also Once
and OnceCapture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@07akioni this needs a rebase, and it would be great if you could add the other event times mentioned above as well.
0714432
to
891c4d6
Compare
Size report
|
It seems the CI fail is irrelevant |
Can this be achieved through LibraryManagedAttributes and Template Literal Types? Instead of enumerating? Like this one #3096 |
I did some exploration #3198 |
bb9c18b
to
9729ab5
Compare
I've done some simplification from #3198. (And as mentioned in 3198 prettier doesn't work due to template literal.) Thanks to @HcySunYang 's idea. |
@07akioni Great, I will close my PR |
This introduces reliance on template literal types, which requires TS > 4.1, so I think we should avoid introducing it in a patch release. I'm not sure if it even makes sense to bump minimum TS compatibility versions in 3.1, but I don't think there are easy ways around this. We'd be either stuck with TS 4.0 and never be able to use template literal types (which is useful in other areas) until next major (unlikely), or we have to introduce a new minimum TS version requirement in a minor release. |
Closing this in favour of #9542 Created a new PR since this PR implementation was not playing nicely with the types when I resolved conflicts |
Currently vue tsx definition doesn't support capture events.