-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
chore: fix type check error #13366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix type check error #13366
Conversation
WalkthroughThe updates involve minor TypeScript adjustments: one adds a non-null assertion to a property in the Changes
Poem
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/server-renderer/__tests__/webStream.spec.ts (1)
51-53
: Suppress TS error with a cast.The
writable as any
assertion fixes the type-check issue without affecting runtime behavior. For stricter typing, consider casting toWritableStream<Uint8Array>
instead ofany
.packages/compiler-sfc/src/compileScript.ts (1)
1319-1327
: Fix type check with non-null assertion.Adding
!
tom.originalColumn
resolves the TypeScript error. For added runtime safety, you could also guard againstoriginalColumn
being null before mapping:- if (m.originalLine == null) return + if (m.originalLine == null || m.originalColumn == null) return
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/compiler-sfc/src/compileScript.ts
(1 hunks)packages/server-renderer/__tests__/webStream.spec.ts
(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/server-renderer/__tests__/webStream.spec.ts (1)
packages/server-renderer/src/renderToStream.ts (1)
pipeToWebWritable
(182-214)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules
- GitHub Check: Header rules
- GitHub Check: Pages changed
哭了,我本来想改来着,你先改了,不过这里的 |
这里是test,其实无所谓 |
Summary by CodeRabbit