feat: Support uri fragment in transformed require #22
Conversation
|
Just for the records: originally requested on ktsn/vue-template-loader#49 |
lib/templateCompilerModules/utils.ts
Outdated
| if(urlString){ | ||
| // A TypeError is thrown if urlString is not a string | ||
| // @see https://nodejs.org/api/url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost | ||
| if('string' === typeof urlString){ |
There was a problem hiding this comment.
urlString is of type string. Is this really required?
There was a problem hiding this comment.
Was assuming pure JS library user, so no tsc validation. Defensive.
If not really required, should there be a catch block? Or what's the expected upper error handling concept? Anyone upper expected to log that error?
lib/templateCompilerModules/utils.ts
Outdated
| export function urlToRequire (url: string): string { | ||
| let returnValue = `"${url}"` |
lib/templateCompilerModules/utils.ts
Outdated
|
|
||
| const uriParts = parseUriParts(url) | ||
|
|
||
| !uriParts.hash |
There was a problem hiding this comment.
Use if block and return early. Avoid using mutable variables.
There was a problem hiding this comment.
ok on if instead of ternary and return early;
not totally sure what is meant with mutable variables; pls comment on next commit
lib/templateCompilerModules/utils.ts
Outdated
| function parseUriParts(urlString: string): UrlWithStringQuery{ | ||
| // initialize return value | ||
| const returnValue : UrlWithStringQuery = uriParse(""); | ||
| if(urlString){ |
There was a problem hiding this comment.
It seems that the code style is not consistent with the existing code. It seems that we should add a linting tool here. @znck
There was a problem hiding this comment.
replaced double quotes with single quotes, if that is all you have meant
|
Please make sure to follow existing code style:
|
plus minor spelling correction
plus minor spelling correction
plus minor spelling correction
plus minor spelling correction
|
Sorry for the merge foxtrot - please squash. |
My case for this PR is a svg within a html based vue component, where i deployed
vue-template-loaderfor this usage. In this html i put a svg element as inRoot cause is that the whole href is generated by
component-compiler-utilsand as-is is required by webpack; this must fail because the whole href - including the uri fragment#menu- is not part of any mapped physical file location of such an svg.