Skip to content

docs: fix issue with autofocus on custom directives page #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 29, 2024

Conversation

NaokiHaba
Copy link
Contributor

@NaokiHaba NaokiHaba commented Sep 27, 2024

resolve #2305#2325

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-ja ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 8:11am

Copy link
Member

@jay-es jay-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
何点かコメントしたのでご確認お願いします 🙏

Copy link
Member

@jay-es jay-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、追加で2個所修正お願いします 🙇

Comment on lines 127 to 128
</script>
<template>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、前回確認漏れてました。こちらも空行追加お願いします 🙇

Suggested change
</script>
<template>
</script>
<template>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改行が漏れておりましたので修正しました🙇

02b104a

Comment on lines 140 to 141
}
export default {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも空行追加お願いします 🙏

Suggested change
}
export default {
}
export default {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改行が漏れておりましたので修正しました🙇

02b104a

Copy link
Member

@jay-es jay-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございました! 🙇

@jay-es jay-es merged commit 94430c8 into vuejs-translations:main Sep 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: fix issue with autofocus on custom directives page
2 participants