Skip to content

docs: Translate Components In-Depth > Props #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2020
Merged

docs: Translate Components In-Depth > Props #60

merged 2 commits into from
Sep 23, 2020

Conversation

n-makoto
Copy link
Collaborator

resolve #13 Components In-Depth > Props の翻訳

@netlify
Copy link

netlify bot commented Sep 19, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit fc3fe5e

https://deploy-preview-60--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻訳ありがとうございます!
レビュー 👀 コメント 💬 しました。

対応お願いします!


```js
props: ['title', 'likes', 'isPublished', 'commentIds', 'author']
```

Usually though, you'll want every prop to be a specific type of value. In these cases, you can list props as an object, where the properties' names and values contain the prop names and types, respectively:
しかし、通常はすべてのプロパティを特定の型の値にしたいと思うでしょう。このような場合には、プロパティをオブジェクトとして列挙し、プロパティのキーと値にそれぞれプロパティの名前と型を設定します。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいですが、 : は日本語翻訳側の方でも、句点(。)ではなく同じにしておいください! 🙏

@n-makoto
Copy link
Collaborator Author

@kazupon
レビューありがとうございます!
指摘いただいた箇所修正しましたのでご確認お願いいたします 🙏

@kazupon
Copy link
Member

kazupon commented Sep 23, 2020

修正ありがとうございました!
確認しました。
CIでエラーが起きていますが、翻訳に支障はない(別事象)ので、マージしますね!

@kazupon kazupon merged commit f09a697 into vuejs-jp:lang-ja Sep 23, 2020
@kazupon
Copy link
Member

kazupon commented Sep 23, 2020

翻訳ありがとうございました!

@n-makoto
Copy link
Collaborator Author

こちらこそありがとうございました!貴重な体験が出来て良かったです🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components In-Depth > Props の翻訳
2 participants