Skip to content

Vue and Web Componentsを翻訳 #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 16, 2021
Merged

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Aug 15, 2021

@naokie
一応レビューお願いします!

@netlify
Copy link

netlify bot commented Aug 15, 2021

✔️ Deploy Preview for vuejs-v3-ja-doc-preview ready!

🔨 Explore the source changes: 3d953a5

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-v3-ja-doc-preview/deploys/611a05859650f10008dbcc28

😎 Browse the preview: https://deploy-preview-479--vuejs-v3-ja-doc-preview.netlify.app

@kazupon
Copy link
Member Author

kazupon commented Aug 15, 2021

lint error を回避するために、この翻訳と関係ないところもfixしてます。
80d133b

@kazupon kazupon mentioned this pull request Aug 15, 2021
7 tasks
@kazupon
Copy link
Member Author

kazupon commented Aug 16, 2021

vuejs/docs#1181 も適用済み

Copy link
Member

@naokie naokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazupon
ありがとうございます!
いくつかミスがあったので、修正よろしくお願いします 🙏🏼

kazupon and others added 3 commits August 16, 2021 15:27
Co-authored-by: Naoki Endoh <naokie@users.noreply.github.com>
Co-authored-by: Naoki Endoh <naokie@users.noreply.github.com>
Co-authored-by: Naoki Endoh <naokie@users.noreply.github.com>
@kazupon
Copy link
Member Author

kazupon commented Aug 16, 2021

@naokie
ありがとうございます!
レビュー指摘内容、取り込みました!
問題なければ、マージお願いします!

Copy link
Member

@naokie naokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です!

@naokie naokie merged commit 38cb29a into lang-ja Aug 16, 2021
@naokie naokie deleted the translation/vue-web-components branch August 16, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants