Skip to content

Contribute to the Docs > Documentation Style Guide の翻訳 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Katakuranatsumi
Copy link
Contributor

@Katakuranatsumi Katakuranatsumi commented Nov 3, 2020

resolve #130

https://v3.vuejs.org/guide/contributing/doc-style-guide.html を翻訳しましたmm
お時間ある時にレビューをお願い致します🙏

@netlify
Copy link

netlify bot commented Nov 3, 2020

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit 205a995

https://deploy-preview-157--vuejs-v3-ja-doc-preview.netlify.app

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

基本良さそうですが、 VuePress の拡張文法の部分だけ修正お願いします!


```
::: info
You can find more information at this site.
::: 情報
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
::: 情報
::: info

あーこの辺りなんですが、 ::: <type> の形式は VuePress の拡張記法なので、基本的に変えないでください!

https://deploy-preview-157--vuejs-v3-ja-doc-preview.netlify.app/guide/contributing/doc-style-guide.html#%E3%82%A2%E3%83%A9%E3%83%BC%E3%83%88

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potato4d
レビューありがとうございますmm
失礼しました、 205a995 で修正しました🙏

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ありがとうございましたー!

@potato4d potato4d merged commit f87ad93 into vuejs-jp:lang-ja Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribute to the Docs > Documentation Style Guide の翻訳
2 participants