fix unbind tooltip

[anhnhoktvn]

No description provided.

[DonNicoJs]

@anhnhoktvn thank you for the pr, we should use the same approach for popups. Could you update the pr?

[anhnhoktvn]

Sure

[DonNicoJs]

@anhnhoktvn hi thanks for the update. I was checking the source code but at the moment I am far from my pc for few days. I will review the pr again next week

[bezany]

@anhnhoktvn Hello! Thanks for you PR.
But I'm confused between the new code and the already existing code in the mixin Layer (unbindTooltip and unbindPopup). Look like it is same code.
Current code have any bug in this? Maybe try create unit test for control regression?

[anhnhoktvn]

@bezany yes, I found a bug while using with rotated marker.
http://imgur.com/JLDjqDjl.png

[DonNicoJs]

@anhnhoktvn Okay now I see the issue, rotated-marker is not one of our core components and do not implement the layer mixin. @bezany what do you think ? should we fix our side or should we ask the other plugin to import our layer mixin ?

[bezany]

@DonNicoJs Interesting case. Anyway, I think need done code more safe through added checks that this.parentContainer.unbindPopup exists.
And I think we can do additional checks for more stable works with plugins.
Can combine both versions of the code?
Like this:

if (this.parentContainer) {
	if (this.parentContainer.unbindPopup) {
		this.parentContainer.unbindPopup();
	} else if (this.parentContainer.mapObject
		&& this.parentContainer.mapObject.unbindPopup) {
		this.parentContainer.mapObject.unbindPopup();
	}
}

Not elegant, but reliable.

[anhnhoktvn]

@DonNicoJs @bezany I updated the code following @bezany 's suggestion. Does anything need to be done?

[DonNicoJs]

@anhnhoktvn no it's all good! Merging and thank you. I will do a release soon.