Skip to content

Default fill to false on Polylines #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/mixins/circle.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
### Props
```js
{
fill: {
type: Boolean,
custom: true,
default: true
},
radius: {
type: Number,
default: null
Expand Down
2 changes: 1 addition & 1 deletion docs/mixins/path.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
fill: {
type: Boolean,
custom: true,
default: true
default: false
},
fillColor: {
type: String,
Expand Down
11 changes: 9 additions & 2 deletions docs/mixins/polygon.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
### Props

`Polygon` does not have any props
```js
{
fill: {
type: Boolean,
custom: true,
default: true
}
}
```

### Methods

Expand Down
5 changes: 5 additions & 0 deletions src/mixins/Circle.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ import Path from './Path';
export default {
mixins: [Path],
props: {
fill: {
type: Boolean,
custom: true,
default: true
},
radius: {
type: Number,
default: null
Expand Down
2 changes: 1 addition & 1 deletion src/mixins/Path.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export default {
fill: {
type: Boolean,
custom: true,
default: true
default: false
},
fillColor: {
type: String,
Expand Down
7 changes: 7 additions & 0 deletions src/mixins/Polygon.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@ import Polyline from './Polyline';

export default {
mixins: [Polyline],
props: {
fill: {
type: Boolean,
custom: true,
default: true
}
},
mounted () {
this.polygonOptions = this.polyLineOptions;
},
Expand Down