Skip to content

noUiSlider fix #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2016
Merged

Conversation

lionel-bijaoui
Copy link
Member

Fix some problem described in #71 and add some enhancement:

  • to help style the field, some class are applied dynamically (for pips and tooltips)
  • schema is updated along with data to generate income data and to uncomment rangeSlider (I accidentally commented it in a previous update)
  • a small change on a condition to avoid "undefined value" warning

A unit test was deactivated since I was not able to trigger a change in model. 😞
I don't know how to simulate a click somewhere on the range slider or have it ready to use.
I give up for now, since the field clearly work as expected anyway. It represent too much work for me right now. Hope that's ok.

@lionel-bijaoui lionel-bijaoui mentioned this pull request Sep 22, 2016
2 tasks
@icebob
Copy link
Member

icebob commented Sep 22, 2016

Thanks. But I create an issue with this skipped test, that we don't forget it.

@icebob icebob merged commit 45de4b1 into vue-generators:master Sep 22, 2016
@lionel-bijaoui
Copy link
Member Author

Thank you, I was about to create the issue ! :)

@lionel-bijaoui lionel-bijaoui deleted the lb_noUiSlider_fix branch September 22, 2016 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants